FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

make the CSS tag around plugin output changeable.

 
Post new topic   Reply to topic    PyLucid - CMS - Forum Forum Index -> plugins
View previous topic :: View next topic  
Author Message
jens
Administrator


Joined: 12 Oct 2005
Posts: 972
Location: duisburg, germany
PostPosted: Thu 20 Mar, 2008 18:11    Post subject: make the CSS tag around plugin output changeable. Reply with quote
We should discuss the ticket http://trac.pylucid.net/ticket/141 here Wink

nano wrote:
Or we decide that an plugin should decide itself if it is in an additional tag. Because if you change the internal pages for your design you sometimes don't want the plugins to have additional tags. So I think we need a great discussion here and then a decision.

There exist CSS_TAG_BLACKLIST here:
http://trac.pylucid.net/browser/trunk/pylucid/PyLucid/template_addons/lucidTag.py?rev=1365#L35

But yes, every Plugin should decide if SPAN, DIV or nothing should used...
We can add a config variable into the plugin_manager_data?
_________________

http://www.jensdiemer.de | http://www.htfx.de | http://www.python-forum.de
Back to top
View user's profile Send private message
sepharim



Joined: 27 Dec 2007
Posts: 180
Location: Germany
PostPosted: Fri 07 Nov, 2008 01:04    Post subject: Reply with quote
hm what about killing the additional Tag? Because if we want an additional Tag we can write it in the template.

If we have reasons for using the additional Tag, than we should fix the id's because if you use a plugin twice, than you have two similiar id's and as far as i know id SHOULD be unambiguous.
Back to top
View user's profile Send private message
sepharim



Joined: 27 Dec 2007
Posts: 180
Location: Germany
PostPosted: Wed 12 Nov, 2008 13:37    Post subject: Reply with quote
sorry overlooked the number, sorry.

But my question exists nevertheless, why do we realy need them?
Back to top
View user's profile Send private message
jens
Administrator


Joined: 12 Oct 2005
Posts: 972
Location: duisburg, germany
PostPosted: Wed 12 Nov, 2008 14:17    Post subject: Reply with quote
nano wrote:
But my question exists nevertheless, why do we realy need them?

Hm. I didn't need them, yet.
But if you use a plugin more than one time, you can select the output individuality via the ID's... With the class you can only select all outputs...
_________________

http://www.jensdiemer.de | http://www.htfx.de | http://www.python-forum.de
Back to top
View user's profile Send private message
sepharim



Joined: 27 Dec 2007
Posts: 180
Location: Germany
PostPosted: Wed 12 Nov, 2008 18:01    Post subject: Reply with quote
Wouldn't it be better to fill a template variable with the ID, so if you need them you can put
Code:

<div id="{{ id_var }}">
....
</div>


in your Code, or you simply extend the existing tag?

The reason why I speak about that is, because one Design I have to do, must be compatible with IE5 and this stupid part of ............ makes Designerrors with the additional tag.
Back to top
View user's profile Send private message
jens
Administrator


Joined: 12 Oct 2005
Posts: 972
Location: duisburg, germany
PostPosted: Thu 13 Nov, 2008 09:41    Post subject: Reply with quote
Hm. The idea is that people can change the look of all outout with CSS only and must not change the internal pages/plugin templates...

The IE doesn't like the current div containers? IMHO this is valide HTML.

btw. We can move the CSS_TAG_BLACKLIST into the settings.py Then you can disable it for specified plugins.
_________________

http://www.jensdiemer.de | http://www.htfx.de | http://www.python-forum.de
Back to top
View user's profile Send private message
sepharim



Joined: 27 Dec 2007
Posts: 180
Location: Germany
PostPosted: Thu 13 Nov, 2008 10:18    Post subject: Reply with quote
There is many more that IE doesn't like. But in most Designs the differences are so small, that you can take it. But in some Designs......

I wrote nearly all my Plugins in CSS_TAG_BLACKLIST Twisted Evil
Perhaps settings.py would be a better place for it.
Back to top
View user's profile Send private message
jens
Administrator


Joined: 12 Oct 2005
Posts: 972
Location: duisburg, germany
PostPosted: Thu 13 Nov, 2008 16:07    Post subject: Reply with quote
http://trac.pylucid.net/ticket/235 Wink
_________________

http://www.jensdiemer.de | http://www.htfx.de | http://www.python-forum.de
Back to top
View user's profile Send private message
jens
Administrator


Joined: 12 Oct 2005
Posts: 972
Location: duisburg, germany
PostPosted: Tue 18 Nov, 2008 17:15    Post subject: Reply with quote
jens wrote:
We can move the CSS_TAG_BLACKLIST into the settings.py

Done in http://trac.pylucid.net/changeset/1800
_________________

http://www.jensdiemer.de | http://www.htfx.de | http://www.python-forum.de
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    PyLucid - CMS - Forum Forum Index -> plugins All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum

<< back to PyLucid CMS Homepage



Powered by phpBB © 2001, 2005 phpBB Group